Update to Gradle 4.0.2 #859
Conversation
| @@ -27,7 +27,8 @@ public CoreSanityTest() { | |||
| ManualPipelineRunner.class, | |||
| SubtractionOperation.class, | |||
| Main.class, | |||
| CoreCommandLineHelper.class | |||
| CoreCommandLineHelper.class, | |||
| Pipeline.class | |||
There was a problem hiding this comment.
@JLLeitschuh Can you take a look and see why I had to ignore Pipeline to get it to build?
There was a problem hiding this comment.
The test wouldn't pass or the compiler would fail??
There was a problem hiding this comment.
Tests would not pass.
There was a problem hiding this comment.
Can you paste the stack trace?
There was a problem hiding this comment.
edu.wpi.grip.core.CoreSanityTest > testNulls FAILED
junit.framework.AssertionFailedError: Error in automated nulls test of class edu.wpi.grip.core.Pipeline
If the class is better tested explicitly, you can add testNulls() to edu.wpi.grip.core.PipelineTest
Caused by:
junit.framework.AssertionFailedError: Can't find or create a sample instance for type 'edu.wpi.grip.core.Step'; please provide one using NullPointerTester.setDefault()
There was a problem hiding this comment.
That makes sense. Uhhh.
In the code below this where all the setDefault's are add:
setDefault(Step.class, new MockStep());That should solve this problem.
gradle.properties
Outdated
| org.gradle.cache.tasks=true | ||
| org.gradle.parallel=false | ||
| org.gradle.configureondemand=false | ||
| org.gradle.cache.tasks=false |
There was a problem hiding this comment.
Sure, we can do this, but why is this necessary? The gradle 4.0 default is now to run with parallel true.
There was a problem hiding this comment.
I just updated and removed the file entirely.
There was a problem hiding this comment.
I saw, thats fine. org.gradle.configureondemand=true can speed up the build a bit but its not really that important in this build because its so small.
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
============================================
+ Coverage 51.41% 51.43% +0.01%
Complexity 1146 1146
============================================
Files 247 247
Lines 7955 7956 +1
Branches 539 531 -8
============================================
+ Hits 4090 4092 +2
+ Misses 3679 3678 -1
Partials 186 186 |
closes #858