Re-writing Grip Build to be Strongly Typed #860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #860 +/- ##
============================================
- Coverage 51.45% 51.43% -0.03%
Complexity 1146 1146
============================================
Files 247 247
Lines 7956 7956
Branches 531 531
============================================
- Hits 4094 4092 -2
- Misses 3677 3678 +1
- Partials 185 186 +1 |
JLLeitschuh
changed the title
|
|
||
| idea { | ||
| module { | ||
| scopes["PROVIDED"]?.get("plus")?.add(ideProviderConfiguration) |
There was a problem hiding this comment.
@JacisNonsense is this the correct conversion of the code you had originally?
There was a problem hiding this comment.
I believe so. That should make it all available to IDEA
| } | ||
| } | ||
|
|
||
| fun setupTestSharedLib() { |
There was a problem hiding this comment.
This whole thing needs to be tested. I couldn't get it to work on my machine.
| ] | ||
| } | ||
| mainClassName = jfx.mainClass | ||
| // task testSharedLib() { |
There was a problem hiding this comment.
This task was never configured right. It actually does nothing and all of the exec statements would be run immediately (I think).
I left this here to help me figure out if I ported it wrong.
| } | ||
|
|
||
| evaluationDependsOn(":core") | ||
| evaluationDependsOn(":ui:preloader") |
There was a problem hiding this comment.
I feel like this could be done better since I understand this better now.
| } | ||
| val coreProject = project(":core") | ||
| dependencies { | ||
| compile(project(path = ":core", configuration = "shadow")) |
There was a problem hiding this comment.
We could get rid of this extra level of complexity if we were to fully remove the deployer.
Work in progress