Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update xstream version to 1.4.10 to fix security issue #885

Merged

Conversation

JLLeitschuh
Copy link
Member

No description provided.

@SamCarlberg
Copy link
Member

What security issue?

@JLLeitschuh
Copy link
Member Author

It should basically make our version eye badge no longer show "insecure".
https://www.versioneye.com/java/com.thoughtworks.xstream:xstream/1.4.9

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #885 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #885      +/-   ##
============================================
- Coverage     52.27%   51.74%   -0.54%     
+ Complexity     1163     1158       -5     
============================================
  Files           248      247       -1     
  Lines          7962     7812     -150     
  Branches        533      533              
============================================
- Hits           4162     4042     -120     
+ Misses         3621     3590      -31     
- Partials        179      180       +1

@AustinShalit
Copy link
Member

Change log for reference: http://x-stream.github.io/changes.html

Will test when I get home

@JLLeitschuh
Copy link
Member Author

I can't merge this without one person's approval. (I mean I can if I want to disable the setting) but I don't want to.

Copy link
Member

@AustinShalit AustinShalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to merge this but also don't know what the side affects are. Testing seems to not break anything though.

@JLLeitschuh JLLeitschuh merged commit d38c920 into WPIRoboticsProjects:master Mar 21, 2018
@JLLeitschuh JLLeitschuh deleted the fix/JLL/xstream-version branch March 21, 2018 01:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants