Fix UI tests on Azure #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
=========================================
Coverage ? 52.89%
Complexity ? 1
=========================================
Files ? 329
Lines ? 8892
Branches ? 561
=========================================
Hits ? 4703
Misses ? 3985
Partials ? 204 |
|
@JLLeitschuh Thoughts on why the code coverage dropped so much? |
|
No idea. This doesn't seem like the kind of thing that would cause it. Perhaps there is binary jacoco comparison going on? |
|
I think it might be because there was no coverage report for the latest commit on master. I'm not sure, though |
|
Oh, the UI tests aren't running because Java 11 is being used instead of Java 8 🤦♂️ |
Update TestFX to 4.0.7-alpha
SamCarlberg
force-pushed
the
azure-openjfx-8
branch
from
7e38d52 to
e3170c9
Compare
JLLeitschuh
approved these changes
May 20, 2019
|
ZuluFX is an OpenJDK + OpenJFX build provided by Azul Systems (https://www.azul.com/). We used the embedded Zulu JRE on the RoboRIO for the 2018 FRC season |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Linux for running the UI tests
Install OpenJFX and openjdk through
apt