Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add example of Modify (redefine) response only to particular endpoint #37

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

pavelsr
Copy link
Contributor

@pavelsr pavelsr commented May 10, 2024

Summary

First off all, Sean @WSH032, thanks for this library

I added one more example to Advanced usage

My example can be useful for API A/B testing or hiding particular methods of upstream

Close: #36

Checklist

  • I've read CONTRIBUTING.md.
  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@WSH032
Copy link
Owner

WSH032 commented May 10, 2024

Hi @pavelsr ! Well done! 🎉 Every pull request targeting the documentation is appreciated! Thank you for your contribution!

I have left some reviews, could you take a look at them?

The CI pipeline encountered some errors, but don't worry, I'll fix it.

@WSH032 WSH032 changed the title Add example of redefining particular endpoint docs: add example of Modify (redefine) response only to particular endpoint May 10, 2024
@WSH032
Copy link
Owner

WSH032 commented May 11, 2024

The CI pipeline encountered some issues from the upstream (codecov/feedback#358).

#28 Upgrading to codecov-action v4 might resolve this issue. I'll test it out and see if the upgrade works.

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (558a86b) to head (89682c5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   96.96%   96.97%   +0.01%     
==========================================
  Files           9        9              
  Lines         461      463       +2     
  Branches       44       35       -9     
==========================================
+ Hits          447      449       +2     
  Misses          9        9              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WSH032
Copy link
Owner

WSH032 commented Jan 14, 2025

ping @pavelsr, do you still want to push this PR? I will modify and merge it today, let me know if you have any comments.

@WSH032
Copy link
Owner

WSH032 commented Jan 14, 2025

I have already made the changes. If you have no other comments, I will merge this PR in a few hours.

@WSH032 WSH032 merged commit ebab5ca into WSH032:main Jan 15, 2025
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of redefining particular endpoint
2 participants