My attempt at replacing fancyhdr with scrlayer-scrpage #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisvogel.tex
Outdated
| \usepackage{ifxetex,ifluatex} | ||
| \ifnum 0\ifxetex 1\fi\ifluatex 1\fi=0 % if pdftex | ||
| \usepackage{iftex} | ||
| \ifpdftex |
There was a problem hiding this comment.
Could you leave these lines as they are? I'm merging with the default template regularly and want to keep merge conflicts to a minimum.
It would be best to include these lines in the pandoc default template and make a pull request.
eisvogel.tex
Outdated
| @@ -51,6 +51,7 @@ | |||
| $endif$ | |||
| % | |||
| \documentclass[ | |||
| version=last, | |||
There was a problem hiding this comment.
This line can be removed since version=last is the default.
eisvogel.tex
Outdated
| @@ -74,7 +75,7 @@ | |||
| $for(classoption)$ | |||
| $classoption$$sep$, | |||
| $endfor$ | |||
| ,captions=tableheading | |||
This reverts commit a778f6b.
|
@Wandmalfarbe, I have made all the changes you requested for. I think you can merge it now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested and found no visual difference between the files produced with fancyhdr and scrlayer-scrpage. Now, the warnings issued by LuaLaTeX are silenced. Feel free to improve upon my code.
I also fixed the ifxetex & ifluatex legacy package warnings and replaced the complicated
if pdftexchecks with a simpler macro.