Skip to content

Commit

Permalink
modify bridgesupport in order to fix `cameraWithLatitude:longitude:zo…
Browse files Browse the repository at this point in the history
…om:' type `@@:ddf' error
  • Loading branch information
Watson1978 committed Feb 22, 2013
1 parent 3d5a773 commit 6f3785f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions vendor/GoogleMaps.framework/GoogleMaps.framework.bridgesupport
Original file line number Diff line number Diff line change
Expand Up @@ -23,32 +23,32 @@
<method class_method='true' selector='cameraWithLatitude:longitude:zoom:'>
<arg index='0' name='latitude' declared_type='CLLocationDegrees' type='d'/>
<arg index='1' name='longitude' declared_type='CLLocationDegrees' type='d'/>
<arg index='2' name='zoom' declared_type='id' type='@'/>
<arg index='2' name='zoom' declared_type='CGFloat' type='f'/>
<retval declared_type='GMSCameraPosition*' type='@'/>
</method>
<method class_method='true' selector='cameraWithLatitude:longitude:zoom:bearing:viewingAngle:'>
<arg index='0' name='latitude' declared_type='CLLocationDegrees' type='d'/>
<arg index='1' name='longitude' declared_type='CLLocationDegrees' type='d'/>
<arg index='2' name='zoom' declared_type='id' type='@'/>
<arg index='2' name='zoom' declared_type='CGFloat' type='f'/>
<arg index='3' name='bearing' declared_type='CLLocationDirection' type='d'/>
<arg index='4' name='viewingAngle' declared_type='double' type='d'/>
<retval declared_type='GMSCameraPosition*' type='@'/>
</method>
<method class_method='true' selector='cameraWithTarget:zoom:'>
<arg index='0' name='target' declared_type='CLLocationCoordinate2D' type='{_CLLocationCoordinate2D=dd}'/>
<arg index='1' name='zoom' declared_type='id' type='@'/>
<arg index='1' name='zoom' declared_type='CGFloat' type='f'/>
<retval declared_type='GMSCameraPosition*' type='@'/>
</method>
<method class_method='true' selector='cameraWithTarget:zoom:bearing:viewingAngle:'>
<arg index='0' name='target' declared_type='CLLocationCoordinate2D' type='{_CLLocationCoordinate2D=dd}'/>
<arg index='1' name='zoom' declared_type='id' type='@'/>
<arg index='1' name='zoom' declared_type='CGFloat' type='f'/>
<arg index='2' name='bearing' declared_type='CLLocationDirection' type='d'/>
<arg index='3' name='viewingAngle' declared_type='double' type='d'/>
<retval declared_type='GMSCameraPosition*' type='@'/>
</method>
<method selector='initWithTarget:zoom:bearing:viewingAngle:'>
<arg index='0' name='target' declared_type='CLLocationCoordinate2D' type='{_CLLocationCoordinate2D=dd}'/>
<arg index='1' name='zoom' declared_type='id' type='@'/>
<arg index='1' name='zoom' declared_type='CGFloat' type='f'/>
<arg index='2' name='bearing' declared_type='CLLocationDirection' type='d'/>
<arg index='3' name='viewingAngle' declared_type='double' type='d'/>
<retval declared_type='id' type='@'/>
Expand Down

10 comments on commit 6f3785f

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finding that rake clean and followed by rake results in the changes above being restored back to prior values. Any idea what would cause that?

@Watson1978
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you manage the GoogleMaps.framework.bridgesupport file by using git etc?

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the problem - if I get it working in folder A, git commit -am "woo it's working", clone it from that repo to another fresh location on the same machine (i.e. should be exactly the same, apart from /build, right?), then run rake build -> some facet of the build process causes the file to revert back to how it was, and thus it doesn't work - very strange.

Here is the result of rake run on the new repo clone:
Screen Shot 2013-02-28 at 23 10 19

Here is the result of git st after running rake (there were no modified files prior to running build)
Screen Shot 2013-02-28 at 23 12 55

Here is git diff of the GoogleMaps.framework.bridgesupport file, showing the changes after build.
Screen Shot 2013-02-28 at 23 13 06

This is my .gitignore:

.repl_history
build
tags
app/pixate_code.rb
resources/*.nib
resources/*.momd
resources/*.storyboardc
.DS_Store
nbproject
#*#
*~
*.sw[po]
.eprj
.sass-cache
#RubyMine
.idea

#Redcar
.redcar

#SublimeText
.dat*

#Cocoapods
vendor/Pods
vendor/Podfile.lock

#Vendor generated files
build-iPhoneOS
build-iPhoneSimulator
.build

@Watson1978
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When GoogleMaps.framework.bridgesupport was changed,
then you could roll back it with git checkout vendor/GoogleMaps.framework/GoogleMaps.framework.bridgesupport

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true - except that if it's changed back each time I run build, this can't fix the problem.

@Watson1978
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once .bridgesupport file was generated, its file will not be updated by rake.
@iandundas, could you send me your project or publish on github?

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a strange sequence of events - though it's only my own fault I don't fully understand the part played by the bridgesupport file yet.

The steps to get it working go as follows:

Step 1. clone a 'working' repo to a new folder

git clone git@bitbucket.org:IanDundas/richardtaylor.songdrop.git songdrop_jukebox_bitbucket
cd songdrop_jukebox_bitbucket

Step 2. rake build returns:

ERROR! Building vendor project vendor/GoogleMaps.framework' failed to create at least one.a' library.

also, this step changed .bridgesupport file, so do a revert of that file

git checkout vendor/GoogleMaps.framework/GoogleMaps.framework.bridgesupport

Step 3. rake build again:

ERROR! Building vendor project vendor/GoogleMaps.framework' failed to create at least one.a' library.` error

ok fine - build still didn't work, despite fixing the .bridgesupport file so..

Step 4. Let's run rake clean and rake build:

ERROR! Building vendor project vendor/GoogleMaps.framework' failed to create at least one.a' library.

argh - still receiving this message. Now, without changing anything, run...

Step 5. rake build one more time - and now it works.

The puzzle is - why after running rake clean && rake build does the bridgesupport file not get changed for a second time?

Many thanks for your help so far!! I'm emailing you permissions to the repo, and also a link to a working version (/build, et al).

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has there been any progress on this does anyone know?

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the repaired GoogleMaps.framework.bridgesupport file is incomplete. For example, I've just crashed with error:

Objective-C stub for message `markerWithPosition:' type `@@:{?=dd}' not precompiled. Make sure you properly link with the framework or library that defines this message.

markerWithPosition: is not mentioned in GoogleMaps.framework.bridgesupport :( surely it should be?

@iandundas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck, ignore that noise. You've updated it for the newest version of the SDK, but because I had to copy/paste from this commit to get it to compile, I lost the new changes. derp.

Please # to comment.