Fix crafting recipe producing incorrect armor

WeaponMechanics · Sep 20, 2022 · 66f4d15 · 66f4d15
1 parent 9116a2c
commit 66f4d15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,7 +1,7 @@
 import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 
 group = "me.cjcrafter"
-version = "1.3.8"
+version = "1.3.9"
 
 plugins {
     `java-library`

diff --git a/src/main/java/me/cjcrafter/armormechanics/ArmorSerializer.java b/src/main/java/me/cjcrafter/armormechanics/ArmorSerializer.java
@@ -18,7 +18,7 @@ public ArmorSerializer() {
     @Nonnull
     @Override
     public ItemStack serialize(SerializeData data) throws SerializerException {
-        ItemStack item = super.serialize(data);
+        ItemStack item = super.serializeWithoutRecipe(data);
 
         if (!isArmor(item))
             throw data.exception("Type", "Material was not a valid armor type", SerializerException.forValue(item.getType()));
@@ -30,10 +30,10 @@ public ItemStack serialize(SerializeData data) throws SerializerException {
         CompatibilityAPI.getNBTCompatibility().setString(item, "ArmorMechanics", "armor-title", title);
 
         // Register the effects
-        ArmorMechanics.INSTANCE.armors.put(title, item);
+        ArmorMechanics.INSTANCE.armors.put(title, item.clone()); // clone... just in case
         ArmorMechanics.INSTANCE.effects.put(title, effect);
 
-        return item;
+        return super.serializeRecipe(data, item);
     }
 
     public static boolean isArmor(ItemStack item) {