- added optimized dump-autoload after di:compile to make sure that it contains dynamically generated classes #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Magento recipe does not run
composer dump-autoload
aftersetup:di:compile
.This means that all classes generated dynamically by Magento DI are not included in composer classmap and all references to those classes during runtime generate performance degradation caused by excessive file_exists calls.
Running
dump-autoload
afterdi:compile
is recommended by official docs:https://experienceleague.adobe.com/en/docs/commerce-operations/performance-best-practices/deployment-flow#preprocess-dependency-injection-instructions
and also included in the default deployer recipe maintained by the community:
https://github.com/deployphp/deployer/blob/master/recipe/magento2.php#L169
Hence I propose adding it in the default recipe. I tested it directly on one of the projects, giving 20-40ms performance gain on average request.