Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use one iframe for openlogin #57

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Use one iframe for openlogin #57

merged 2 commits into from
Nov 17, 2021

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Nov 17, 2021 •
edited
Loading

  • Fully backward compatible
  • Solves issues regarding vuex-shared-mutations
  • reduces load time by 50%

tetratorus
tetratorus approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@tetratorus tetratorus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tetratorus
tetratorus approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@tetratorus tetratorus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

himanshuchawla009
himanshuchawla009 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit b28d85e into master Nov 17, 2021
@chaitanyapotti chaitanyapotti deleted the feat/one-iframe branch November 17, 2021 10:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tetratorus tetratorus tetratorus approved these changes

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaitanyapotti @tetratorus @himanshuchawla009