Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use unfiltered share descriptions so that tss share description is not filtered out #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

metalurgical
Copy link
Contributor

@metalurgical metalurgical commented Feb 5, 2025

This PR removes the filter applied to the underlying share descriptions, thereby returning all results.

@AyushBherwani1998
Copy link
Member

While testing it looks like it considers every share as hashed share.

"{\"0370d5cb4bf05041da97ce846e990d93c9897292d30f0593ee2f908b7627b07982\":[\"{\\\"tssIndex\\\":3,\\\"module\\\":\\\"hashedShare\\\",\\\"dateAdded\\\":1738821836}\"],\"0396a0d61f447bb0b8430a69a9248384825d32fc02945d17532228677f6db6caf6\":[\"{\\\"module\\\":\\\"hashedShare\\\",\\\"tssIndex\\\":2,\\\"dateAdded\\\":1738821830}\"],\"04b168b23024b615c91719942b0b6ba6b26c23b1f5ec5c0726ecc8e03472ed9695f0818d622188d6f7ec0b280deeb7e1929a03318ecace8d57b4208a72865ebfef\":[\"{\\\"module\\\":\\\"hashedShare\\\",\\\"tssIndex\\\":2,\\\"dateAdded\\\":1738821814}\"]}"

My MFA is enabled, so hashedShare details shouldn't be there, and since I have enabled the MFA there should be device share and recovery share instead of hashedShare module?

@metalurgical
Copy link
Contributor Author

metalurgical commented Feb 7, 2025

While testing it looks like it considers every share as hashed share.

"{\"0370d5cb4bf05041da97ce846e990d93c9897292d30f0593ee2f908b7627b07982\":[\"{\\\"tssIndex\\\":3,\\\"module\\\":\\\"hashedShare\\\",\\\"dateAdded\\\":1738821836}\"],\"0396a0d61f447bb0b8430a69a9248384825d32fc02945d17532228677f6db6caf6\":[\"{\\\"module\\\":\\\"hashedShare\\\",\\\"tssIndex\\\":2,\\\"dateAdded\\\":1738821830}\"],\"04b168b23024b615c91719942b0b6ba6b26c23b1f5ec5c0726ecc8e03472ed9695f0818d622188d6f7ec0b280deeb7e1929a03318ecace8d57b4208a72865ebfef\":[\"{\\\"module\\\":\\\"hashedShare\\\",\\\"tssIndex\\\":2,\\\"dateAdded\\\":1738821814}\"]}"

My MFA is enabled, so hashedShare details shouldn't be there, and since I have enabled the MFA there should be device share and recovery share instead of hashedShare module?

This is unrelated to this PR, all this PR does is remove the filter that was applied to the underlying descriptions when returning the key details.

@metalurgical
Copy link
Contributor Author

Close #39

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants