Fix table exporting #4736
Merged
Fix table exporting #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I reduced the testcase in the linked issue until it was obvious from reading the diff after roundtripping. And since the bug only happens in the binary format, and just during writing, I read that code and got a surprise 😄 |
|
Are there any estimates for the date of the next release, with this fix in it? |
Merged
|
@torokati44 I released version 110 now, https://github.com/WebAssembly/binaryen/releases/tag/version_110 (builds still running) |
|
Wow, that was quick! Thank you so much! We won't have to build for ourselves in CI now. |
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was apparently not updated when we added multi-table support,
and still had the old hardcoded index 0.
Fixes #4711