Handle return calls in CodeFolding #6474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
tlively
force-pushed
the
return-call-code-folding
branch
2 times, most recently
from
702e897 to
e608ce4
Compare
tlively
changed the title
|
cc @vouillon |
tlively
force-pushed
the
return-call-code-folding
branch
2 times, most recently
from
873166b to
a72c996
Compare
tlively
force-pushed
the
return-call-effects
branch
from
b4affd2 to
5ff3513
Compare
tlively
force-pushed
the
return-call-code-folding
branch
from
a72c996 to
e422e13
Compare
kripken
reviewed
Apr 5, 2024
| ) | ||
| (unreachable) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
did we not have a test for this before?
There was a problem hiding this comment.
No, not that I was able to find for either of these tests. Except for the throws effect analysis, the implementation does not seem to special case try-catch at all, so it's reasonable that we wouldn't need tests for the success cases. But when I was trying to debug and figure out how to get this change working, it was useful to prove to myself locally that similar cases did already work correctly.
| ) | ||
| ) | ||
| (i32.const 0) | ||
| ) |
tlively
force-pushed
the
return-call-code-folding
branch
3 times, most recently
from
e424ec1 to
6b593a0
Compare
tlively
force-pushed
the
return-call-code-folding
branch
from
6b593a0 to
837aa77
Compare
Treat them the same as returns and test that they can be folded out of try-catch blocks because they do not have throws effects.
tlively
force-pushed
the
return-call-code-folding
branch
from
837aa77 to
dc796d4
Compare
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat them the same as returns and test that they can be folded out of try-catch
blocks because they do not have throws effects.