Consistent naming conventions for signedness, addendum #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This naming would fit nicely with the convention and is more informative.
|
lgtm. I can see arguments both ways here; thinking of arithmetic right shift as a signed integer operation entails thinking of it as performing a division operation that rounds differently from |
|
lgtm |
rossberg
added a commit
that referenced
this pull request
Sep 5, 2015
Consistent naming conventions for signedness, addendum
|
I updated LLVM accordingly: |
earl
pushed a commit
to earl/llvm-mirror
that referenced
this pull request
Sep 8, 2015
Renamed from: WebAssembly/design#332 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247028 91177308-0d34-0410-b5e6-96231b3b80d8
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fit nicely with the convention and is more informative.