Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Spec infrastructure and full, deterministic profiles #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Spec infrastructure and full, deterministic profiles #5

wants to merge 3 commits into from

Conversation

rossberg
Copy link
Member

conrad-watt
conrad-watt reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@conrad-watt conrad-watt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on holiday until January 11th and don't have an easy way to render the doc, but everything I can see through the github diff interface lgtm.

@ngzhian
Copy link
Member

ngzhian commented Dec 12, 2022

LGTM, thanks Andreas! I'll use a similar notation in the relaxed-simd spec.
@conrad-watt you can preview the changes here: https://www.ngzhian.com/profiles/core/appendix/profiles.html

@ngzhian ngzhian mentioned this pull request Dec 12, 2022
Closed
@lukewagner lukewagner mentioned this pull request Dec 20, 2022
Open
@ngzhian ngzhian mentioned this pull request Jan 17, 2023
Open
@ngzhian
Copy link
Member

ngzhian commented Jan 25, 2023

Any suggestion how this would look like in the English description? A similar !DET annotation beside the bullet point?

image

@rossberg
Copy link
Member Author

Good question. Something like

b. [!DET] Text...

might work, but we may need to consider more examples to see how that works.

@ngzhian
Copy link
Member

ngzhian commented Feb 15, 2023

Sg. I don't have a need for this yet, because I delegate to operations defined in exec/numerics, and the [!DET] part is contained in exec/numerics.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@conrad-watt conrad-watt conrad-watt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossberg @ngzhian @conrad-watt