-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
rename 'runtime' interface name to 'store' #14
Conversation
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Thanks! To your question: originally, there was a sketch to use value imports to import configuration values, with 1 value import per individual configuration value, allowing the names of required configuration values to be known declaratively, allowing various DX/security/perf improvements. But that was a much bigger lift (for the tooling and runtime), so we instead prioritized adding a more-dynamic (runtime) configuration interface (which we'd need in any case, since sometimes you just don't know AOT what configuration you need), hence the name of the repo. Whatever the history, renaming the repo to wasi-config to match |
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just words, no code
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for improving upon my suggestions. LGTM!
Could you please take a look? @thomastaylor312 |
And I am all good with a repo rename |
It renames:
runtime
->store
config-error
->error
and
delete the hand-written
config.md
in preference of the generatedimports.md
doc. Closes #13question: I remember we briefly discussed this but I forgot about the rationals behind the subtle difference between the proposal name "wasi-runtime-config" and the actual WIT package name "wasi:config", what are the reasons? Could we rename this repo to "wasi-config" but keeps runtime configuration as an option in the README? @thomastaylor312 @lukewagner