Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop -ms suffix for request options #85

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

alexcrichton
Copy link
Contributor

This is a leftover artifact from recent refactorings but now that it's using a duration type which holds its value in nanoseconds the -ms suffix is no longer required.

Closes #78

This is a leftover artifact from recent refactorings but now that it's
using a `duration` type which holds its value in nanoseconds the `-ms`
suffix is no longer required.

Closes WebAssembly#78
@elliottt
Copy link
Collaborator

Could you also remove the references to milliseconds in the request-options resource docs?

@pchickey pchickey requested a review from lukewagner November 28, 2023 01:52
@ricochet ricochet self-requested a review November 28, 2023 14:59
@pchickey pchickey merged commit c6fb95f into WebAssembly:main Nov 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are timeouts on request options specified in milliseconds or nanoseconds?
5 participants