Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use llvm 12.0.0 release #178

Merged
merged 3 commits into from
Apr 20, 2021
Merged

use llvm 12.0.0 release #178

merged 3 commits into from
Apr 20, 2021

Conversation

pchickey
Copy link
Collaborator

No description provided.

sbc100
sbc100 approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@jedisct1
Copy link
Member

Exciting!

Not so much; it was tagged even though 13 known regressions since LLVM 11 are still open.

https://bugs.llvm.org/show_bug.cgi?id=48902
https://twitter.com/andy_kelley/status/1382443048571785216

I wouldn't rush.

@sunfishcode sunfishcode mentioned this pull request Apr 19, 2021
Closed
@pchickey
Copy link
Collaborator Author

Of those regressions, it only looks like 2 of the regressions are miscompilations in InstCombine. I don't know for sure if those could affect wasm32-wasi. I'm inclined to go ahead and release on top of 12.0.0 unless @sbc100 can indicate that a 12.0.1 is coming shortly.

@sbc100
Copy link
Member

sbc100 commented Apr 20, 2021

In emscripten we have seen some regressions due to the new pass manager.. but I think we planning on simply accepting them.

@sbc100
Copy link
Member

sbc100 commented Apr 20, 2021

I'm not following the plans for a 12.0.1 release.

@pchickey pchickey merged commit a927856 into main Apr 20, 2021
@pchickey pchickey deleted the pch/llvm_12 branch April 20, 2021 17:32
@pchickey
Copy link
Collaborator Author

pchickey commented Apr 20, 2021 •
edited
Loading

Thanks. Sounds like we should just go ahead with a release based on 12.0.0, and do another release whenever upstream does.

@sbc100 sbc100 mentioned this pull request Sep 15, 2021
Closed
@sbc100 sbc100 mentioned this pull request Sep 29, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchickey @jedisct1 @sbc100