Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump wasi-libc #340

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Bump wasi-libc #340

merged 1 commit into from
Aug 22, 2023

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Aug 14, 2023

I want to include WebAssembly/wasi-libc#409 which is rather easy to hit when people are experimenting wasi-threads.

@sbc100
Copy link
Member

sbc100 commented Aug 14, 2023

This diff looks wrong somehow. The commit you are trying to update to in wasi-libs (ec3ee5e) seems to be from 3 years ago: ec3ee5e98541a89b9db016005fa0e9f0287fd755

I want to include WebAssembly/wasi-libc#409
which is rather easy to hit when people are experimenting wasi-threads.
@yamt
Copy link
Contributor Author

yamt commented Aug 15, 2023

This diff looks wrong somehow. The commit you are trying to update to in wasi-libs (ec3ee5e) seems to be from 3 years ago: ec3ee5e98541a89b9db016005fa0e9f0287fd755

oops. fixed.

@Zzzabiyaka
Copy link

Hi

Can we please include WebAssembly/wasi-libc#433 as well ?

@yamt
Copy link
Contributor Author

yamt commented Aug 16, 2023

Hi

Can we please include WebAssembly/wasi-libc#433 as well ?

if/when that PR get merged before this PR, i probably update this to include that.
otherwise, i can file another PR to bump the version again.

@abrown abrown merged commit 4025e95 into WebAssembly:main Aug 22, 2023
@yamt yamt mentioned this pull request Sep 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants