Avoid extra Cargo installation artifacts #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't yet verified this works but wanted to do this before I forget. |
|
I tried this out locally and the build failed for other reasons! $ NINJA_FLAGS=-v make package
...
/.../wasi-sdk/build/install/opt/wasi-sdk/bin/llvm-ar crs build/wasm32-wasi/libc.so.a
/.../wasi-sdk/build/install/opt/wasi-sdk/bin/clang --target=wasm32-wasi -nodefaultlibs -shared --sysroot=/.../wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot \
-o /.../wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot/lib/wasm32-wasi/libc.so -Wl,--whole-archive build/wasm32-wasi/libc.so.a -Wl,--no-whole-archive /.../wasi-sdk/build/install/opt/wasi-sdk/lib/clang/18/lib/wasi/libclang_rt.builtins-wasm32.a
wasm-ld: warning: creating shared libraries, with -shared, is not yet stable
wasm-ld: error: duplicate symbol: accept
>>> defined in build/wasm32-wasi/libc.so.a(accept.pic.o)
>>> defined in build/wasm32-wasi/libc.so.a(accept-wasip1.pic.o)
wasm-ld: error: duplicate symbol: accept4
>>> defined in build/wasm32-wasi/libc.so.a(accept.pic.o)
>>> defined in build/wasm32-wasi/libc.so.a(accept-wasip1.pic.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:587: /.../wasi-sdk/build/install/opt/wasi-sdk/share/wasi-sysroot/lib/wasm32-wasi/libc.so] Error 1
make[1]: Leaving directory '/.../wasi-sdk/src/wasi-libc'
make: *** [Makefile:150: build/wasi-libc.BUILT] Error 2I wonder if something is failing in the build that is being masked by our action caching? |
alexcrichton
reviewed
Jul 8, 2024
There was a problem hiding this comment.
I ran into the same error you're seeing but the problem was a stale build directory for wasi-libc (I something about in-tree builds made it easier to get into this stale state). Given that CI is green I think this change is ok.
I'll note as well that this was also fixed in #429, but I think it's fine for this to land orthogonal to that.
alexcrichton
approved these changes
Jul 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @bjorn3 mentioned in #420, using
--no-trackshould get rid of the extra files that show up after thecargo install. Fixes #420.