Add instructions to export WPT changes #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
reviewed
May 3, 2023
|
|
||
| The export process for WPT consists of the following: | ||
|
|
||
| 1. Commit your changes and run: |
There was a problem hiding this comment.
You mean commit your changes locally.
stwrt
requested changes
May 3, 2023
| Tools/Scripts/export-w3c-tests -g HEAD -b BUG_ID -c --no-linter | ||
| ``` | ||
|
|
||
| 2. In the newly created pull request, enable auto-merge (if you have access) |
There was a problem hiding this comment.
Is this pull request for the WPT repo or WebKit repo?
|
|
||
| 2. In the newly created pull request, enable auto-merge (if you have access) | ||
|
|
||
| 3. Once the WebKit commit lands, the pull request will be automatically approved by a bot. |
There was a problem hiding this comment.
A little confused does the export-w3c-tests export both a WPT and WebKit PR?
|
Thinking about this some more do we want to merge the two articles into one on handling WPT tests? Could just be called |
rniwa
reviewed
May 5, 2023
| 1. Commit your changes and run: | ||
|
|
||
| ``` | ||
| Tools/Scripts/export-w3c-tests -g HEAD -b BUG_ID -c --no-linter |
There was a problem hiding this comment.
This should be Tools/Scripts/export-w3c-test-changes
|
Here is the old doc that looks more complete https://trac.webkit.org/wiki/WPTExportProcess but not sure if is still 100% up-to-date. Maybe there is some info from there that is worth adding here |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.