Adding NamedNodeMap to global export #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2021 09:21
that object is expected to be in the global context when running jest test (for Axe checks)
mikemadest
commented
Jul 19, 2021
|
|
||
| let node = document.documentElement.firstElementChild; | ||
|
|
||
| assert(typeof NamedNodeMap !== 'undefined', true, 'NamedNodeMap undefined in global export'); |
There was a problem hiding this comment.
My intention was to add a unit test related to the change here. I couldn't find similar checks for other exported objects but felt bad not adding something...
| @@ -30,6 +30,7 @@ import {InputEvent} from './input-event.js'; | |||
| import {ImageClass} from './image.js'; | |||
| import {MutationObserverClass} from './mutation-observer.js'; | |||
| import {NodeList} from './node-list.js'; | |||
| import {NamedNodeMap} from './named-node-map.js'; | |||
There was a problem hiding this comment.
Do you mind moving this above the previous line? Just to preserve the alphabetical order, thanks!
There was a problem hiding this comment.
Of course, thanks for your feedback 👍
|
Thanks, beside one line to move, this looks good to me 👍 |
mikemadest
added a commit
to mikemadest/linkedom
that referenced
this pull request
Jul 21, 2021
* Adding NamedNodeMap to global export
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this PR is this error when running Axe tests in a React app,
using Jest with a linkedom environment:
And this is the axe test involved:
What happen is that
NamedNodeMap, despite being in linkedom interface, wasn't available inwindow, which is what this PR intend to change.