Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Verify add-on package checksums when installing. #701

Merged
merged 4 commits into from
Mar 1, 2018

Conversation

mrstegeman
Copy link
Contributor

No description provided.

@mrstegeman mrstegeman requested a review from hobinjk February 21, 2018 21:38
@ghost ghost assigned mrstegeman Feb 21, 2018
@ghost ghost added the review label Feb 21, 2018
@codecov-io
Copy link

codecov-io commented Feb 22, 2018

Codecov Report

Merging #701 into master will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   80.25%   80.27%   +0.01%     
==========================================
  Files          82       82              
  Lines        3368     3305      -63     
  Branches      429      417      -12     
==========================================
- Hits         2703     2653      -50     
+ Misses        619      606      -13     
  Partials       46       46
Impacted Files Coverage Δ
src/addon-manager.js 71.07% <100%> (-0.59%) ⬇️
src/controllers/addons_controller.js 67.22% <75%> (+2.08%) ⬆️
src/utils.js 92.85% <92.85%> (ø)
src/app.js 63.12% <0%> (-3.78%) ⬇️
src/ssltunnel.js 29.41% <0%> (-1.36%) ⬇️
src/addons/plugin/addon-manager-proxy.js 74.44% <0%> (-1.35%) ⬇️
src/tunnel_setup.js 85.71% <0%> (-0.96%) ⬇️
src/controllers/settings_controller.js 30.27% <0%> (-0.64%) ⬇️
src/db.js 82.03% <0%> (-0.32%) ⬇️
config/default.js 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e26b79...1f2de1a. Read the comment docs.

@mrstegeman mrstegeman closed this Feb 22, 2018
@mrstegeman mrstegeman deleted the checksums branch February 22, 2018 19:28
@ghost ghost removed the review label Feb 22, 2018
@mrstegeman mrstegeman restored the checksums branch March 1, 2018 15:40
@mrstegeman mrstegeman reopened this Mar 1, 2018
@ghost ghost added the review label Mar 1, 2018
@mrstegeman mrstegeman merged commit 18afec1 into WebThingsIO:master Mar 1, 2018
@ghost ghost removed the review label Mar 1, 2018
@mrstegeman mrstegeman deleted the checksums branch March 1, 2018 15:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants