Sanitize HTML and URLs. #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 78.93% 78.93%
=======================================
Files 84 84
Lines 3408 3408
Branches 448 448
=======================================
Hits 2690 2690
Misses 660 660
Partials 58 58Continue to review full report at Codecov.
|
hobinjk
reviewed
Mar 5, 2018
static/js/speech.js
Outdated
| @@ -72,7 +72,7 @@ var Speech = { | |||
| var opts = { | |||
| method: 'POST', | |||
| cache: 'default', | |||
| body: `{"text":"${results[0].text}"}`, | |||
| body: `{"text":"${results[0].text.replace(/"/g, '\\"')}"}`, | |||
There was a problem hiding this comment.
This would be a bit more general as
body: JSON.stringify({text: results[0].text})
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #733