Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Display author on add-ons pages. #758

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Display author on add-ons pages. #758

merged 2 commits into from
Mar 14, 2018

Conversation

mrstegeman
Copy link
Contributor

Fixes #739

@ghost ghost assigned mrstegeman Mar 14, 2018
@ghost ghost added the review label Mar 14, 2018
@mrstegeman
Copy link
Contributor Author

screen shot 2018-03-14 at 08 17 40

@codecov-io
Copy link

codecov-io commented Mar 14, 2018 •
edited
Loading

Codecov Report

Merging #758 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #758   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files          85       85           
  Lines        3446     3446           
  Branches      452      452           
=======================================
  Hits         2722     2722           
  Misses        665      665           
  Partials       59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9652de4...eed9f3c. Read the comment docs.

benfrancis
benfrancis approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@benfrancis benfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@benfrancis
Copy link
Member

benfrancis commented Mar 14, 2018 •
edited
Loading

Nit: Could you change "Created by:" to just "by" for brevity?

It would be nice to also include an optional URL for the author like Firefox Add-ons do. e.g.

screenshot from 2018-03-14 16-07-57

@mrstegeman
Copy link
Contributor Author

Done.

screen shot 2018-03-14 at 12 35 28

@mrstegeman mrstegeman merged commit f814dd8 into WebThingsIO:master Mar 14, 2018
@ghost ghost removed the review label Mar 14, 2018
@mrstegeman mrstegeman deleted the author branch March 14, 2018 19:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benfrancis benfrancis benfrancis approved these changes

@hobinjk hobinjk Awaiting requested review from hobinjk

Assignees

@mrstegeman mrstegeman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrstegeman @codecov-io @benfrancis