Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a busy timeout to db.open(). #775

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Conversation

mrstegeman
Copy link
Contributor

While not a complete fix, this is probably the best we can do to
handle this gracefully.

Fixes #772

While not a complete fix, this is probably the best we can do to
handle this gracefully.

Fixes WebThingsIO#772
@mrstegeman mrstegeman requested a review from dhylands March 20, 2018 13:34
@ghost ghost assigned mrstegeman Mar 20, 2018
@ghost ghost added the review label Mar 20, 2018
@codecov-io
Copy link

codecov-io commented Mar 20, 2018

Codecov Report

Merging #775 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   78.84%   78.85%   +<.01%     
==========================================
  Files          85       85              
  Lines        3456     3457       +1     
  Branches      452      452              
==========================================
+ Hits         2725     2726       +1     
  Misses        672      672              
  Partials       59       59
Impacted Files Coverage Δ
src/db.js 80.34% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6e11f...9842aa2. Read the comment docs.

Copy link
Contributor

@dhylands dhylands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was more or less what I was thinking of.

@mrstegeman mrstegeman merged commit 7887055 into WebThingsIO:master Mar 20, 2018
@ghost ghost removed the review label Mar 20, 2018
@mrstegeman mrstegeman deleted the db-open branch March 20, 2018 15:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db.open sometimes fails
3 participants