Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement add-on actions and events. #806

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

mrstegeman
Copy link
Contributor

Fixes #717

@mrstegeman mrstegeman requested review from dhylands and hobinjk March 27, 2018 13:26
@ghost ghost assigned mrstegeman Mar 27, 2018
@ghost ghost added the review label Mar 27, 2018
@mrstegeman
Copy link
Contributor Author

This is going to fail on Travis CI until the following PR is merged: WebThingsIO/gateway-addon-node#4

Copy link
Contributor

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to have and LGTM, nice work!

@codecov-io
Copy link

Codecov Report

Merging #806 into master will decrease coverage by 0.55%.
The diff coverage is 76.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
- Coverage   78.79%   78.23%   -0.56%     
==========================================
  Files          85       87       +2     
  Lines        3466     3570     +104     
  Branches      455      470      +15     
==========================================
+ Hits         2731     2793      +62     
- Misses        675      710      +35     
- Partials       60       67       +7
Impacted Files Coverage Δ
src/rules-engine/effects/ActionEffect.js 90.47% <ø> (ø) ⬆️
src/plugin/plugin.js 76.38% <0%> (-4.5%) ⬇️
src/addons-test/mock-adapter/mock-adapter.js 91.93% <100%> (+0.55%) ⬆️
src/controllers/actions_controller.js 100% <100%> (ø) ⬆️
src/router.js 97.91% <100%> (+0.04%) ⬆️
src/constants.js 100% <100%> (ø) ⬆️
src/controllers/things_controller.js 93.18% <100%> (+0.21%) ⬆️
src/models/thing.js 96.36% <100%> (+1.81%) ⬆️
src/models/events.js 23.07% <23.07%> (ø)
src/plugin/addon-manager-proxy.js 71.81% <46.66%> (-3.98%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdadf61...0d72cd6. Read the comment docs.

@hobinjk
Copy link
Contributor

hobinjk commented Mar 27, 2018

It would be nice to have a test of actions and events through mock-adapter but that can be left to future work if you'd prefer.

@mrstegeman
Copy link
Contributor Author

@hobinjk We should definitely do that. The actions, things, and rules engine tests already test the actions interface pretty thoroughly, and the rules engine tests events, but it would be good to expand that a bit.

@mrstegeman mrstegeman merged commit bcda077 into WebThingsIO:master Mar 27, 2018
@ghost ghost removed the review label Mar 27, 2018
@mrstegeman mrstegeman deleted the actions-events branch March 27, 2018 15:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants