Provide access to the Access Tokens API and enable initialization from OAuth Authentication Codes and Refresh Tokens #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide access to the access_tokens API wrapper directly from the WebexTeamsAPI class *before* instantiating an instance of the class (which requires an access token). Also provide convenience class methods that will instantiate a new WebexTeamsAPI connection object from an OAuth Authorization Code or Refresh Token.
|
I like the idea! Let me review the code a bit more in-depth. |
|
Happy with these changes. I'll merge the PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sQu4rks, I know you added support for #61 by extending the initializer for the WebexTeamsAPI class. What do you think of this alternative solution?
This PR provides access to the access_tokens API wrapper directly from the WebexTeamsAPI class before instantiating an instance of the class. Also, provides convenience class methods that will instantiate a new WebexTeamsAPI connection object from an OAuth Authorization Code or Refresh Token.
Example Accessing the Access Tokens API:
Example Create WebexTeamsAPI Connection Objects from OAuth Access Tokens or Refresh Tokens: