Windows fix for popen and unicode_literals + import_project CLI #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchubby
force-pushed
the
windows-subprocess-import-fixes
branch
from
e95fc3e to
09223e2
Compare
second fix for glob-related windows bugs fix for realpath() and windows backslashes
mchubby
force-pushed
the
windows-subprocess-import-fixes
branch
from
09223e2 to
85795df
Compare
nijel
added a commit
that referenced
this pull request
Apr 12, 2016
Always use / as path separator even on Windows, see issue #1067 Signed-off-by: Michal Čihař <michal@cihar.com>
nijel
added a commit
that referenced
this pull request
Apr 12, 2016
This will allow us to do some sanity checking there. Issue #1067 Signed-off-by: Michal Čihař <michal@cihar.com>
nijel
added a commit
that referenced
this pull request
Apr 12, 2016
It can not handle ascii unicode objects unlike other platforms. Issue #1067 Signed-off-by: Michal Čihař <michal@cihar.com>
|
Thanks for your patch, however I've decided to fix this differently. Main problems with your approach:
My commits to address this issue: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes subprocess.call() on Windows due to use of future unicode_literals (see nephila/djangocms-installer#228 and jazzband/pip-tools#209), when invoking manage.py migrate.
Also fixes
get_matching_files()in import_project.py with glob.glob() returning paths with forward slashes.EDIT: squashed two more commits for another glob() and os.path.realpath() calls.