Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(discovery): disable edit_template if format does not support it #12855

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 24, 2024

Proposed changes

Otherwise user gets an error which is hard to understand.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.8.2 milestone Oct 24, 2024
@nijel nijel self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.14%. Comparing base (53c5ad5) to head (2472411).
Report is 3314 commits behind head on main.

Files with missing lines Patch % Lines
weblate/trans/discovery.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12855      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         596      596              
  Lines       61191    61214      +23     
  Branches     6349     6350       +1     
==========================================
+ Hits        55780    55792      +12     
- Misses       3758     3767       +9     
- Partials     1653     1655       +2     
Files with missing lines Coverage Δ
weblate/trans/discovery.py 91.05% <71.42%> (-0.76%) ⬇️

... and 2 files with indirect coverage changes

Otherwise user gets an error which is hard to understand.
@nijel nijel force-pushed the discover-edit-template branch from 5090f5b to 2472411 Compare October 24, 2024 10:58
@nijel nijel enabled auto-merge (rebase) October 24, 2024 10:58
@nijel nijel merged commit f98b182 into WeblateOrg:main Oct 24, 2024
33 of 35 checks passed
@nijel nijel deleted the discover-edit-template branch October 24, 2024 13:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant