Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added explicit file ending to sh files #72

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

abubakrsiddq
Copy link
Contributor

This is with reference to #64

When repo is clone, sometimes the line ending cause problems during docker build, so I have added gitattributes to define line ending on the sh files explicitly.

Also, I have just added a new line at the end of the .sh file and normalized them.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2023
@slawlor
Copy link
Contributor

slawlor commented Jan 9, 2023

Thanks for this! Did you run a re-normalization of the existing files with

git add --renormalize .

?

If you could and update the PR that'd be great, then we can get it merged

@abubakrsiddq
Copy link
Contributor Author

Thanks for this! Did you run a re-normalization of the existing files with

git add --renormalize .

?

If you could and update the PR that'd be great, then we can get it merged

yes ran this

Copy link

@shoaib9804725 shoaib9804725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iran: tested on Windows 10 , works for some and doesn't for others
6 participants