Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Require OTP 25 #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Require OTP 25 #4

wants to merge 2 commits into from

Conversation

robertoaloi
Copy link
Contributor

CI currently fails due to Dialyzer relying on OTP 25 specs:

===> Analyzing 22 files with _build/default/rebar3_24.3.4.3_plt...

src/wa_raft_acceptor.erl
Line 63 Column 29: Unknown type gen_server:from/0
Line 95 Column 25: Unknown type gen_server:server_ref/0
Line 179 Column 25: Unknown type gen_server:from/0

src/wa_raft_queue.erl
Line 108 Column 60: Unknown type gen_server:from/0
Line [22](https://github.com/WhatsApp/waraft/runs/8045238407?check_suite_focus=true#step:9:23)2 Column 64: Unknown type gen_server:from/0
Line 303 Column 46: Unknown type gen_server:from/0

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 1, 2022
@facebook-github-bot
Copy link
Contributor

@ilya-klyuchnikov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robertoaloi robertoaloi force-pushed the switch-ci-to-otp-25 branch from 9b55d3b to 0fb712e Compare April 3, 2023 19:13
@robertoaloi robertoaloi force-pushed the switch-ci-to-otp-25 branch from 43eb2d5 to b98fd09 Compare April 3, 2023 19:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ValanGracious ValanGracious ValanGracious approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertoaloi @facebook-github-bot @ValanGracious