Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Digital IO Docs #780

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Conversation

GeorgeStephens
Copy link
Contributor

Updated CreateDigitalInterruptPort and CreateDigitalInputPort.

CreateDigitalInputPort previously included parameters for CreateDigitalInterruptPort.

Note that there is still an ambiguity in Glitch and Debounce filters as it states '0' to disable. Should this be 'TimeSpan.Zero'?

jorgedevs and others added 4 commits June 11, 2024 19:20
Updated CreateDigitalInterruptPort and CreateDigitalInputPort.

CreateDigitalInputPort previously included parameters for CreateDigitalInterruptPort.

Note that there is still an ambiguity in Glitch and Debounce filters as it states '0' to disable. Should this be 'TimeSpan.Zero'?
@patridge
Copy link
Collaborator

@GeorgeStephens Thank you for starting this!

I'm not sure I'm looking in the right place, but the only overloads I see take pin and resistor mode. So, maybe glitch and debounce are not valid in this context.

I'm going to update the text following these examples, but I'll try to nail down if those parameters are needed for input ports.

@adrianstevens adrianstevens changed the base branch from main to develop January 7, 2025 23:41
@adrianstevens adrianstevens merged commit f514515 into WildernessLabs:develop Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants