Future incompatibility warning because of steamy-vdf's dependency on nom 1.2.4

[mtkennerly]

I opened a ticket for steamy-vdf, but since it doesn't seem to be maintained, I thought it was worth raising here as well for awareness.

Using Rust 1.68.0, this warning is displayed while building:

warning: the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4

[CosmicHorrorDev]

Thanks for the notice!

Something that would be extremely helpful would be more testing with #9. Just seeing if there are any parsing/deserialization issues on any manifests is the big one

[parasyte]

FWIW, I'm now using the dev-v2.0 branch with my project, and it is working fine!

[CosmicHorrorDev]

2.0.0-alpha.0 was just published and includes the changes to fully drops steamy-vdf including its dependency on nom v1.2.4

There will be significant changes before the actual v2 release for steamlocate, but this should let people drop the transitive steamy-vdf dependency without having to rely on git dependencies

Leaving this issue open for visibility

[mtkennerly]

I don't think there's anything to change here, but just figured I'd mention it in case anyone else runs into it. I tried integrating 2.0.0-alpha.0, and Windows Defender complained about there being a trojan. However, I wasn't able to reproduce it after rebuilding, and Virus Total didn't find any issues, so ¯\_(ツ)_/¯ Otherwise, it's working fine.

[CosmicHorrorDev]

Rust is pretty good at getting false positives from anti-viruses because one of its initial popular uses was in malware. Mostly because static-linking makes portable executables and cross compiling a lot easier (Go is also popular here for the same reason)

[CosmicHorrorDev]

steamy-vdf is now fully dropped from our dep tree with the 2.0 release