Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

provide all args for core.cleanup #53

Merged
merged 1 commit into from
Oct 17, 2021
Merged

provide all args for core.cleanup #53

merged 1 commit into from
Oct 17, 2021

Conversation

9001
Copy link
Contributor

@9001 9001 commented Sep 25, 2021

this PR fixes the invocation of core.cleanup from the GUI, which was missing one required argument

@WaxyMocha WaxyMocha self-assigned this Sep 25, 2021
@dmgolembiowski
Copy link

dmgolembiowski commented Oct 3, 2021

@WaxyMocha and @9001 thanks for this! I'm using it to prepare an installation media for Windows 11 insider today from Debian. It builds without any errors!

There is one thing to consider; after burning the iso to an external usb mount (with all contents of the ISO successfully copied), the program hangs indefinitely on the page "Unmounting and removing /media/woeusb_target".
On stdout+stderr, I see:

/dev/sdb: 5 bytes were erased at offset 0x00008001 (iso9660): 43 44 30 30 31
/dev/sdb: 2 bytes were erased at offset 0x000001fe (dos): 55 aa
/dev/sdb: 8 bytes were erased at offset 0x00000200 (gpt): 45 46 49 20 50 41 52 54
/dev/sdb: 2 bytes were erased at offset 0x00000000 (mac): 45 52
/dev/sdb: calling ioctl to re-read partition table: Success
Cluster size has been automatically set to 4096 bytes.
Creating NTFS volume structures.
mkntfs completed successfully. Have a nice day.
grub-install: error: /usr/lib/grub/i386-pc/modinfo.sh doesn't exist. Please specify --target or --directory.

due to a wine installation's supplemental architecture packages. It's (obviously) not part of the normal system, but I figured this might be worth reporting for additional error handling. Is it appropriate to yank it without waiting for an exit?

@9001
Copy link
Contributor Author

9001 commented Oct 3, 2021

I believe this is because you don't have the package grub-pc-bin installed, so it should work correctly if you try again after running apt install grub-pc-bin.

However, this shouldn't be a problem for all modern computers, as grub is only required for legacy BIOS.
Just make sure the filesystem on the usb is unmounted -- and run sync for good measure -- before you unplug it :)

Copy link
Member

@WaxyMocha WaxyMocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you check my comments and address them?

WoeUSB/core.py Show resolved Hide resolved
WoeUSB/gui.py Show resolved Hide resolved
@WaxyMocha WaxyMocha merged commit 4ddbd21 into WoeUSB:master Oct 17, 2021
WaxyMocha added a commit that referenced this pull request Oct 28, 2021
 Changes:
- #53; provide all args for core.cleanup
- #56; uefi image bigger than 512 KiB
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants