Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP OPL3 MIDI2VGM #250

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

WIP OPL3 MIDI2VGM #250

wants to merge 15 commits into from

Conversation

freq-mod
Copy link

@freq-mod freq-mod commented Nov 26, 2021

WIP, not ready to merge at all. Could say it was barely started...
TODO:

  • implement VGM file dumper that at least works
  • implement handling embedded banks/ OPL3 stuff like drum mode, 4op voices
  • prolly fix formatting/indentation 🥴
  • update VGM to >1.5.1 to get OPL3 support (started)
  • and a lot more ig...

@freq-mod
Copy link
Author

In file included from ../src/adlmidi_opl3.cpp:66:0:
../src/chips/vgm_file_dumper.h:26:56: error: expected template-name before ‘<’ token
class VGMFileDumper final : public ADLChipBaseBufferedT<VGMFileDumper>

../src/chips/vgm_file_dumper.h:26:56: error: expected ‘{’ before ‘<’ token
../src/chips/vgm_file_dumper.h:26:56: error: expected unqualified-id before ‘<’ token

Don't know why it is hapeens, maybe something obvious eludes me

@freq-mod
Copy link
Author

freq-mod commented Dec 1, 2021

OK, figured that one out... still borked though.

@freq-mod
Copy link
Author

freq-mod commented Dec 1, 2021

../src/adlmidi_opl3.cpp: In member function ‘void OPL3::reset(int, long unsigned int, void*)’:
../src/adlmidi_opl3.cpp:1813:75: error: cannot allocate an object of abstract type ‘VGMFileDumper’
chip = new VGMFileDumper(i, (i == 0 ? NULL : m_chips[0].get()));

can't get any further 😔

@Wohlstand
Copy link
Owner

../src/adlmidi_opl3.cpp: In member function ‘void OPL3::reset(int, long unsigned int, void*)’: ../src/adlmidi_opl3.cpp:1813:75: error: cannot allocate an object of abstract type ‘VGMFileDumper’ chip = new VGMFileDumper(i, (i == 0 ? NULL : m_chips[0].get()));

can't get any further pensive

You also should change the body at vgm_file_dumper.cpp too 👀

to match the header
@freq-mod
Copy link
Author

freq-mod commented Dec 2, 2021

can't say it helped, still stuck

@freq-mod
Copy link
Author

@Wohlstand once you have some time, can you look onto it?

@Wohlstand
Copy link
Owner

I'll try to get look soon, thanks for the note 😉

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants