Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Copy font assets to the local theme folder when creating a style variation #713

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Copy font assets to the local theme folder when creating a style variation.

Why?

Fixes: #695

How to test:

  • Create a blank theme
  • Install a few font families using the font library
  • Create a variation with those changes and the 'save fonts' option selected.
  • Verify that the fonts were copied to the local theme folder.

Screencast

2024-08-30.12-57-32.mp4

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This is testing well for me 👏

I tested on a blank theme:

  • Creating a style variation with the "Save Fonts" option checked copied the font assets to the theme's directory ✅
  • Creating a style variation with the "Save Fonts" option unchecked did not copy the font assets ✅
  • The "Save Fonts" selection was remembered (checked or unchecked) ✅

@matiasbenedetto
Copy link
Contributor Author

I found an error trying to copy font assets already in the theme. Fixed it here: 884cc70

@matiasbenedetto matiasbenedetto merged commit 27c0fb7 into trunk Sep 20, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the add/save-fonts-in-variation-creation branch September 20, 2024 18:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add fonts to theme assets when a style variation is created.
2 participants