ESLint Plugin: Add missing eslint-plugin-import dependency #28545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Tool] ESLint plugin
Props to @marekdedic for raising the issue and the initial fix proposed in #28525.
gziolo
force-pushed
the
fix/eslint-plugin-import
branch
from
34456be to
119dbb0
Compare
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
|
This was referenced Mar 18, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative to #28525 opened by @marekdedic. The difference is that it removes
eslint-plugin-importfrom Gutenberg dependencies since it's used only in the package now. Changes to the lock file were also applied.Closes #28391.
How has this been tested?
I checked whether
npm run lint-jsstill works.Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist: