Rename AccessibleSVG to SVG and make it work with React Native

[gziolo]

Description

Follow-up: #9565.
Alternative to: #9294 and #9656.

TODO

• Make it work with the mobile app (React Native).

How has this been tested?

npm test
npm run build - make sure all the SVG-based icons still work.

Types of changes

Refactoring.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[SergioEstevao]

Shouldn't this continue to be Path? in order to get the React-Native version?

[gziolo]

I think temporary it should remain as is.

I was playing with createElement version which would do the replacement behind the scenes, but with no luck so far. I hope to do some more explorations soon.

[SergioEstevao]

But that will make our code in RN fail....

…

On Tue, 25 Sep 2018 at 13:58, Grzegorz (Greg) Ziółkowski < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/components/src/dashicon/index.js <#9685 (comment)>: > @@ -900,7 +900,7 @@ export default class Dashicon extends Component { height={ size } viewBox="0 0 20 20" > - <Path d={ path } /> + <path d={ path } /> I think temporary it should remain as is. I was playing with createElement version which would do the replacement behind the scenes, but with no luck so far. I hope to do some more explorations soon. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#9685 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnxUXHEZrMbnzH0VXHTve2tN8g1SWw0ks5ueihlgaJpZM4Welk3> .

[gziolo]

@SergioEstevao I brought back Native components for SVG, can you double check if it works properly now? I hope to continue alternative solution where you can write DOM tags for SVG body but have RN to convert them to proper components behind the scenes. If it doesn't work we will have to ensure that all SVG use the pattern established so far.

[mcsf]

Polygon is missing; worth showing in the example?

[gziolo]

I don't think it's essential to be include. I don't even know what it translates to :)

[gziolo]

@mzorz, @hypest or @SergioEstevao, can you confirm that this PR works with wordpress-mobile/gutenberg-mobile#129?

[hypest]

👋 @gziolo , I tested out wordpress-mobile/gutenberg-mobile#129 against this branch and, apart from some updating that RN side branch needs, the app actually errors because the paragraph block has the icon being defined using plain, lowercased svg elements.

EDIT: Well, I should add that there's an open PR #9294 for the changes/fixes already.

[gziolo]

Okey, let's merge this one and rebase #9294 against master.

[mtias]

Nice work following up here.

[mzorz]

Okey, let's merge this one and rebase #9294 against master.

#9264 merged 🎉