-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Configure Dominant Color
and Fetchpriority
modules for their standalone plugins
#704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one issue that needs to be addressed before this is merged.
Also, since we're duplicating a lot of code between all the modules in their respective hooks.php
and load.php
files to handle things like avoiding conflicts with the Performance Lab plugin and outputting generator meta tags. I think there is an opportunity to consolidate these types of things to a shared file that got included in each plugin during the build process. There are tradeoffs to consider, for sure, but something we may want to consider.
Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
Agreed. Let's open an issue to think about that further. While coming up with centralized logic for this is probably trivial, we'll likely need to spend some time considering different approaches for how we handle this central logic that still needs to be somehow copied and bundled into all of the standalone plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixarntz! PR look good to me.
@mukeshpanchal27 @10upsimon Since there was a merge conflict and since the two changes are so closely related, I've updated this PR to include the changes in the branch from #708 as well. You can ignore those changes in here for now - let's complete and merge #708 first, and after that we can review the changes actually coming from this PR here. It should only be merged after the 2.2.0 release anyway. |
Summary
Fixes #640.
Do not merge this pull request until the two plugin repositories for these two standalone plugins have been created and approved. Likely this will only be as part of the 2.3.0 milestone.
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.