Skip to content

Conversation

qiuchengxuan
Copy link

the current traverse implemention has several weakness:

  1. unable to stop traverse, thus unable to reduce traverse time
    complexity around O(logN)
  2. out-of-order, ordinary traverse method should be pre-order, in-order,
    post-order, but the current implemention belongs none of them
  3. memory cost, since traversing in flat levels, maximum memory usage
    will reach to nearly half tree width

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

the current traverse implemention has several weakness:
1. unable to stop traverse, thus unable to reduce traverse time
   complexity around O(logN)
2. out-of-order, ordinary traverse method should be pre-order, in-order,
   post-order, but the current implemention belongs none of them
3. memory cost, since traversing in flat levels, maximum memory usage
   will reach to nearly half tree width
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants