Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

separate workflow for sonar #140

Merged

Conversation

mh-northlander
Copy link
Collaborator

@mh-northlander mh-northlander commented Jul 3, 2024

fix #134.

Currently sonarcloud does not provides analysis for PR from forked repo (open issue).
To use secret tokens safely, we can separate workflow for sonar task using workflow_run trigger.

This triggered workflow misses the information about PR and we need to pass it somehow (in this PR, via artifact).

ref: https://community.sonarsource.com/t/how-to-use-sonarcloud-with-a-forked-repository-on-github/7363/30

@mh-northlander mh-northlander changed the title skip sonar for PRs from outside WIP: skip sonar for PRs from outside Jul 3, 2024
@mh-northlander mh-northlander force-pushed the fix/trigger-sonarqube branch from 56cb2ac to af2df2b Compare July 3, 2024 02:21
@mh-northlander mh-northlander changed the title WIP: skip sonar for PRs from outside skip sonar for PRs from outside Jul 3, 2024
@mh-northlander mh-northlander requested a review from kazuma-t July 3, 2024 02:44
@mh-northlander mh-northlander changed the title skip sonar for PRs from outside WIP: skip sonar for PRs from outside Jul 3, 2024
@mh-northlander mh-northlander force-pushed the fix/trigger-sonarqube branch from f9c48d4 to b535a2a Compare July 3, 2024 08:42
@mh-northlander mh-northlander changed the title WIP: skip sonar for PRs from outside separate workflow for sonar Jul 3, 2024
@mh-northlander mh-northlander changed the title separate workflow for sonar wip: separate workflow for sonar Jul 3, 2024
@mh-northlander mh-northlander changed the title wip: separate workflow for sonar separate workflow for sonar Jul 4, 2024
@mh-northlander mh-northlander merged commit b7efaa8 into WorksApplications:develop Jul 4, 2024
24 checks passed
@mh-northlander mh-northlander deleted the fix/trigger-sonarqube branch July 4, 2024 05:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip sonarqube for branches that cannot access secret token
2 participants