Remove OEM deb, rpm and zip packages #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pavelhoral
requested changes
Nov 29, 2022
Those OEM packages are not necessary since the upgraded JE backend is licensed under the Apache License.
fyrbach
force-pushed
the
feature/remove-oem-packages
branch
from
06bb15d to
6400ef1
Compare
pavelhoral
reviewed
Nov 30, 2022
| ! * opendj-deb-standard | ||
| ! * opendj-deb-oem | ||
| ! * opendj-rpm | ||
| ! * opendj-deb | ||
| --> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
AFAIK this is useless as the packaging is of type POM. Default JAR goal gets configured only for JAR packaging.
I have noticed that the former packages were probably of type JAR. But POM is better for those submodules..
pavelhoral
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Changes looks good. There can be more stuff deleted (default-jar configuration), but that can be done later (i.e. in #53 ... cc @karelmaxa ).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those OEM packages are not necessary since the upgraded JE backend is licensed under the Apache License.