Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issues with Rest2LDAP feature #79

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Conversation

pavelhoral
Copy link
Member

This PR fixes multiple issues with REST endpoints and their behavior.

The major change is about reverting unreleased change providing API descriptors for read-only subresources. This change unfortunately broke admin monitor endpoint and there is no simple way to fix that. I don't think API descriptor feature should be blocking project release - hence revert.

@pavelhoral pavelhoral requested a review from karelmaxa April 18, 2023 13:07
Copy link
Member

@karelmaxa karelmaxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@karelmaxa karelmaxa merged commit bb5fc1d into WrenSecurity:main Apr 18, 2023
@karelmaxa karelmaxa deleted the fix-rest branch April 18, 2023 13:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants