Merge branch 'release/5.0.3'

WsdlToPhp · Feb 9, 2023 · f59c085 · f59c085
2 parents 151ffb8 + 81875be
commit f59c085
Show file tree

Hide file tree

Showing 14 changed files with 130 additions and 106 deletions.
diff --git a/CODE_OF_CONDUCT.md → .github/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md → .github/CODE_OF_CONDUCT.md
diff --git a/CONTRIBUTING.md → .github/CONTRIBUTING.md b/CONTRIBUTING.md → .github/CONTRIBUTING.md
diff --git a/.github/workflows/sonars.yml b/.github/workflows/sonars.yml
@@ -0,0 +1,48 @@
+name: Sonars
+on:
+    push:
+        branches:
+            - develop
+            - feature/*
+            - feat/*
+            - release/*
+    pull_request:
+        types: [ opened, synchronize, reopened ]
+jobs:
+    sonarcloud:
+        name: Sonars
+        runs-on: ubuntu-latest
+        steps:
+            -   name: Checkout code
+                uses: actions/checkout@v2
+                with:
+                    fetch-depth: 0
+
+            -   name: Setup PHP with Xdebug
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: 7.4
+                    coverage: xdebug
+
+            -   name: Install dependencies with composer
+                run: composer update --no-ansi --no-interaction --no-progress
+
+            -   name: Generate coverage report with phpunit
+                run: vendor/bin/phpunit --coverage-clover coverage.xml --log-junit report.xml
+
+            -   name: Monitor coverage
+                uses: slavcodev/coverage-monitor-action@v1
+                with:
+                    github_token: ${{ secrets.ACTIONS_GITHUB_TOKEN }}
+                    coverage_path: coverage.xml
+                    threshold_alert: 95
+                    threshold_warning: 90
+
+            -   name: Fix phpunit files paths
+                run: sed -i 's@'$GITHUB_WORKSPACE/'@''@g' coverage.xml report.xml
+
+            -   name: SonarCloud Scan
+                uses: SonarSource/sonarcloud-github-action@master
+                env:
+                    GITHUB_TOKEN: ${{ secrets.ACTIONS_GITHUB_TOKEN }}
+                    SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
diff --git a/.travis.yml b/.travis.yml
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # CHANGELOG
 
+## 5.0.3 - 2023/02/09
+- PR #38 - type checking exception raised in php8
+
 ## 5.0.2 - 2022/08/10
 - PR #44 - Add #[\ReturnTypeWillChange] to AbstractStructArrayBase
 

diff --git a/composer.json b/composer.json
@@ -44,6 +44,10 @@
             "name": "Karl Pierce",
             "email": "kpierce@ratespecial.com",
             "role": "Contributor"
+        },
+        {
+            "name": "maurobn",
+            "role": "Contributor"
         }
     ],
     "support" : {
@@ -58,7 +62,7 @@
     "scripts": {
         "test": "vendor/bin/phpunit",
         "lint": "vendor/bin/php-cs-fixer fix --ansi --diff --verbose",
-        "phpstan": "vendor/bin/phpstan analyze src --level=3"
+        "phpstan": "vendor/bin/phpstan analyze src --level=5"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "~3.0",

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -2,12 +2,8 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" backupGlobals="false" colors="true" bootstrap="vendor/autoload.php">
   <coverage>
     <include>
-      <directory>./</directory>
+      <directory>./src</directory>
     </include>
-    <exclude>
-      <directory>./tests</directory>
-      <directory>./vendor</directory>
-    </exclude>
   </coverage>
   <php>
     <ini name="error_reporting" value="-1"/>

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -0,0 +1,7 @@
+sonar.projectKey=WsdlToPhp_PackageBase
+sonar.organization=wsdltophp
+sonar.php.coverage.reportPaths=coverage.xml
+sonar.php.tests.reportPath=report.xml
+
+sonar.sources=src/
+sonar.tests=tests/
diff --git a/src/AbstractStructArrayBase.php b/src/AbstractStructArrayBase.php
@@ -259,7 +259,7 @@ private function getInternArrayOffset(): int
      * @param bool $internCall indicates that methods is calling itself
      * @return AbstractStructArrayBase
      */
-    private function initInternArray(array $array = [], bool $internCall = false): self
+    private function initInternArray($array = [], bool $internCall = false): self
     {
         if (is_array($array) && count($array) > 0) {
             $this