Fallback to default when requested language is missing, rather than panicking #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
|
This has been released as 0.5.12 |
|
No problem, and thanks for the quick response! |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fairly new to fluent, and in my application I'm setting the requested language id from the user's locale settings, but there's only the one localization at the moment, and it doesn't seem right to have the application panic at runtime if the user's locale differs from the fallback locale.
At the very least I think it should return an error rather than panic, so that it's recoverable, but it seems to me that the requested language not being available is also a situation where the fallback language should be used.
#15 also would help with avoiding the panic, but I think that for most situations it would be sufficient just to use the fallback language, and simpler from the perspective of using the library.