Loader::lookup/lookup_complete/lookup_with_args return Option<String> #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loader::lookup/lookup_complete/lookup_with_args now return Option<String> so the user can control what happens when a lookup returns nothing.
Modified the tests to support the new Option<String> returned by Loader::lookup_complete/lookup_with_args/lookup
Both Tera and Handlebars now return an error from their respective
call() functions if the loader cannot find a lookup for the given id
via:
match response {
Some(response) => Ok(Json::String(response)),
None => Err(...(format!("Unknown localization {}", id))),
}
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
This was referenced Mar 19, 2022
debug-richard
added a commit
to debug-richard/fluent-templates
that referenced
this pull request
May 1, 2023
XAMPPRocky
pushed a commit
that referenced
this pull request
Jul 23, 2023
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loader::lookup/lookup_complete/lookup_with_args now return
Option<String> so the user can control what happens when a lookup
returns nothing.
Ref: #32