Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: wrap pull_request_review_id in an Option #388

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: wrap pull_request_review_id in an Option #388

merged 1 commit into from
Jun 1, 2023

Commits on May 31, 2023

  1. fix: wrap pull_request_review_id in an Option 

    In some instances, the GitHub API returns `null` for the
`pull_request_review_id` field (this seems like a bug on the
GitHub side - the API documentation lists this field as "required").
This happens, for example, here:

https://api.github.com/repos/bitcoin/bitcoin/pulls/1772/comments

To avoid serialization problems, the field is wrapped in an Option.
    @0xB10C
    0xB10C committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c6d0161 View commit details
    Browse the repository at this point in the history