Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add status code to GithubError #607

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Mar 15, 2024

Fixes #598

I could leave the derive(serde::Deserialize) in for GithubError, but what could it be deserialized from? A payload where someone manually stuck status_code into?

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 1cb0d5c into XAMPPRocky:main Mar 19, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
@flying-sheep flying-sheep deleted the github-error-status-code branch March 20, 2024 15:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose status_code in GithubError
2 participants