New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix LD Script language data #1028

Merged

XAMPPRocky merged 2 commits into XAMPPRocky:master from rhysd:fix-ld

Sep 24, 2023

Contributor

rhysd commented Sep 23, 2023 •

edited

Loading

This PR fixes the following points for linker scripts support:

.ld file extension is very common (e.g. Linux kernel).
// line comment is not allowed for linker scripts. The specification only mentions /* and */ as comments. And I confirmed ld actually causes an error as follows.
```
error: kernel.ld:4: unknown directive: //
>>> // hoge
>>> ^
```

rhysd added 2 commits

September 23, 2023 20:57


          Add .ld file extension to LD Script

3b84a86


          Fix LD Script doesn't allow // line comments

3a14a02

Owner

XAMPPRocky commented Sep 24, 2023

Thank you for your PR!

XAMPPRocky merged commit c8e4d07 into XAMPPRocky:master

github-actions bot mentioned this pull request

chore: release v13.0.0-alpha.1 #1070

Merged

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet